Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deny stargateV2 #7825

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: deny stargateV2 #7825

merged 1 commit into from
Sep 26, 2024

Conversation

0xApotheosis
Copy link
Contributor

Description

Issue (if applicable)

Received a heads up from the LiFi team that stargate V1 is being deprecated, and that we should add stargatev2 if we wish to continue blocking stargate.

Screenshot 2024-09-27 at 07 46 19

Risk

High Risk PRs Require 2 approvals

Small

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

LiFi trades

Testing

Ensure we do not see any quotes from Stargate via LiFi.

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner September 26, 2024 21:48
woodenfurniture
woodenfurniture approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@woodenfurniture
Copy link
Member

Context for posterity:
https://discord.com/channels/@me/1080609986541002753/1288814415063552071

Hi Team,

We would like to inform you of a Deprecation Notice for Hyphen and Stargate V1

We noticed in your /routes request filtering the following:

"bridges": {
"deny": [ "stargate", "amarok", "arbitrum" ]}

If you would like to exclude Stargate routes, please replace stargate with stargateV2 in your >bridges deny list.

Please note that the Hyphen bridge will be deprecated alongside Stargate V1 in the near >future. Thank you

@woodenfurniture woodenfurniture merged commit bca1fdb into develop Sep 26, 2024
3 checks passed
@woodenfurniture woodenfurniture deleted the deny-stargate-v2 branch September 26, 2024 22:07
@gomesalexandre gomesalexandre mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xApotheosis @woodenfurniture